Simplify jetbrains account management #6558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkukielka
force-pushed
the
pkukielka/simplify-jetbrains-acc-management
branch
2 times, most recently
from
00cc95f to
5ee8c9f
Compare
pkukielka
commented
Jan 9, 2025
| if (ConfigUtil.isCodyEnabled() && !ConfigUtil.isIntegrationTestModeEnabled()) { | ||
| CodyAgentService.getInstance(project).startAgent(project) | ||
| EndOfTrialNotificationScheduler.createAndStart(project) |
There was a problem hiding this comment.
This we should not need anymore.
abeatrix
approved these changes
Jan 9, 2025
Good question. I added an agent test to prove it works: |
pkukielka
force-pushed
the
pkukielka/simplify-jetbrains-acc-management
branch
from
5ee8c9f to
cff7fb6
Compare
pkukielka
force-pushed
the
pkukielka/simplify-jetbrains-acc-management
branch
from
cff7fb6 to
fc591a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/sourcegraph/issue/CODY-4643/
Fixes https://linear.app/sourcegraph/issue/QA-188/jetbrains-adding-password-in-keychain-will-logout-user-when-same
Retargetting PR from old repo (with some further simplifications):
sourcegraph/jetbrains#2817
Changes
This PR removes custom account management code from JetBrains.
Now account changing is possible only through webview.
JetBrains receives notifications about endpoint change and caches it locally.
JetBrains is also still responsible for storing token tokens through
secrets/*API.But during JetBrains startup we don't specfify current endpoint or token anymore.
Instead we allow cody to manage them by itself. This makes agent fully responsible for auth management. The only exception are tests, where we starts agent with pre-configured endpoint/token.
Test plan
Changelog