backport/jb-v7.4.x: chore(telemetry): remove legacy back-compat (#6265) #6274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When V2 telemetry first launched, we had to be careful to support older instances with V1 event logs, and shortly after the launch there were a series of bug fixes that necessitated several compatibility modes from 5.2.0 to 5.2.5, which was released in December 2023. After 5.2.5, we never committed to removing this back-compat as we waited for customers to slowly upgrade past 5.2.5.
Sadly, this came back to haunt us when 5.10.0 came out a few days ago, and our compatibility mode detector sorted 5.10.0 < 5.2.5, causing V2T to be exported as old event logs, which prevented them from being exported. After finding the bug and discussing it a bit, we've decided to remove this back-compat
entirely since most Cody customers have upgraded past 5.2.5. This simplifies the code significantly.
With the backcompat gone, this basically removes the need for any of the old log-event-to-dotcom stuff, which allowed for the removal for quite a lot of unused code, which simplifies even more stuff.
Closes
https://linear.app/sourcegraph/issue/CORE-103/vscodetelemetry-remove-legacy-v1-fallback-exporter
Test plan
CI, plus a manual test:
Apply a simple patch to make telemetry export in dev without fenangling configuration (this diff is not in this PR):
Run the extension:
In logs:
in the instance:
(cherry picked from commit 717c1d7)