Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/accounts: Do not sign out when removing an unrelated account #6269

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

dominiccooney
Copy link
Contributor

Fixes QA-194.

Test plan

Manual test:

  • Sign in to JetBrains with two accounts.
  • Switch to the Accounts tab, Switch Accounts and remove the second account.
  • Verify that you stay signed in on the accounts tab, and the second account is gone from the account switcher.

Changelog

fix/accounts: Removing a second account does not dump you back at the login screen.

@dominiccooney dominiccooney requested a review from a team December 6, 2024 03:33
Copy link
Contributor

@arafatkatze arafatkatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic of this PR makes sense, and I also verified the behavior by testing.

@dominiccooney dominiccooney enabled auto-merge (squash) December 6, 2024 07:05
@dominiccooney dominiccooney merged commit 7cc7953 into main Dec 6, 2024
18 of 21 checks passed
@dominiccooney dominiccooney deleted the dpc/qa-194-do-not-sign-out-on-remove branch December 6, 2024 07:09
dominiccooney added a commit that referenced this pull request Dec 6, 2024
…nrelated account (#6270)

Fixes QA-194.

## Test plan

Manual test:
- Sign in to JetBrains with two accounts.
- Switch to the Accounts tab, Switch Accounts and remove the second
account.
- Verify that you stay signed in on the accounts tab, and the second
account is gone from the account switcher.

## Changelog

fix/accounts: Removing a second account does not dump you back at the
login screen. <br> Backport 7cc7953
from #6269

Co-authored-by: Dominic Cooney <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants