remove ctrl+shift+L shortcut and update shift+alt+L shortcut #6148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmcnamara
approved these changes
Nov 18, 2024
Comment on lines
+654
to
+663
| { | ||
| "command": "cody.chat.new", | ||
| "key": "shift+alt+l", | ||
| "when": "cody.activated && !editorTextFocus" | ||
| }, | ||
| { | ||
| "command": "cody.chat.new", | ||
| "key": "shift+alt+/", | ||
| "when": "cody.activated && !editorTextFocus" | ||
| }, |
There was a problem hiding this comment.
Does it make sense to leave the existing keybindings in place for Linux and MacOS users and only introduce the new bindings for windows users? Or do we not think people are using these?
Suggested change
| { | |
| "command": "cody.chat.new", | |
| "key": "shift+alt+l", | |
| "when": "cody.activated && !editorTextFocus" | |
| }, | |
| { | |
| "command": "cody.chat.new", | |
| "key": "shift+alt+/", | |
| "when": "cody.activated && !editorTextFocus" | |
| }, | |
| { | |
| "command": "cody.chat.new", | |
| "key": "shift+ctrl+l", | |
| "when": "cody.activated && !editorTextFocus && !isWindows" | |
| }, | |
| { | |
| "command": "cody.chat.new", | |
| "key": "shift+ctrl+/", | |
| "when": "cody.activated && !editorTextFocus && !isWindows" | |
| }, | |
| { | |
| "command": "cody.chat.new", | |
| "key": "shift+alt+l", | |
| "when": "cody.activated && !editorTextFocus && isWindows" | |
| }, | |
| { | |
| "command": "cody.chat.new", | |
| "key": "shift+alt+/", | |
| "when": "cody.activated && !editorTextFocus && isWindows" | |
| }, |
There was a problem hiding this comment.
This just shipped, so I doubt many users are using this, and I'd prefer to maintain some consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shift+Ctrl+L(previously created a new chat) due to conflict with Windows default shortcut.Shift+Alt+Lto create a new chat when the focus is not in the editor. When the focus is in the editor, the behavior remains unchanged (the current selection is added to the chat context).Test plan
Test both shortcuts locally