-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HubSpot Master Forms #5483
Merged
Merged
HubSpot Master Forms #5483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notifying subscribers in CODENOTIFY files for diff d96637a...a4e4401.
|
Merged
st0nebreaker
reviewed
Jul 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so much more simplified 🙌🏻 ! Nice work, Brett. Thanks.
- I see the correct forms loading per page.
- Contact pages are loading great.
- Form data q- I see
first_source_url
hidden field data on HS, but notanonymous_user_id
orform_submission_source
. Are they hidden somewhere on this page?
- For all the Webinar
GatedResourceLayout
forms, one small quirk I notice: After submitting the form & going back in history, the form is absent & no submission messages are present. Before, the HS form reloads here.
st0nebreaker
reviewed
Jul 8, 2022
st0nebreaker
reviewed
Jul 8, 2022
st0nebreaker
previously approved these changes
Jul 19, 2022
fabicastp
approved these changes
Jul 22, 2022
st0nebreaker
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #5409 and consolidates most of our HubSpot forms under 4 master forms that map to specific
formId
s. Some forms that do not fall under the master forms still use the specificformId
backwards compatible syntax in the API.Please take a look at our Master List to understand the mapping as well as the tech requirements.
Changelog
EmbeddedHubSpot
component is now deprecated in favour of one component to rule them all. The new API is much more simplistic for both cases. I will follow up with a PR to update the handbook section for embedded HubSpot forms after this PR is merged.useLandingSource
hook to grab and store the initial landing source of a user insessionStorage
. This will be used to track landing sources in our HubSpot form submission data in case thesourcegraphSourceUrl
cookie doesn't contain any useful dataTest
masterFormName
matchesanonymous_user_id
hidden form field is populated with thesourcegraphAnonymousUid
cookie datafirst_source_url
hidden form field is populated with the landing source or thesourcegraphSourceUrl
if you started your session from the product and navigated to the about site through a CTAform_submission_source
is populated with the page you're submitting the form on. Submit a test submission and ensure all pieces of data are sent and captured in your form submission on HubSpot. You can find your contact in HubSpot by searching in Contacts for the email you used in your form submission.GatedResourceLayout
component and ensure form submission messages with links to the resources open properly when clickedTODO
/demo
, and;/contact/team-pricing