Skip to content
This repository has been archived by the owner on Feb 21, 2025. It is now read-only.

Webinar Recording pg: Code Insights #5442

Merged
merged 12 commits into from
Jun 9, 2022
Merged

Conversation

st0nebreaker
Copy link
Contributor

@st0nebreaker st0nebreaker commented Jun 7, 2022

Closes #5412 by adding a /watch-now recording page for the Code Insights webinar

Changelog

  • Adds watch-now sub-path to the Code Insights webinar page with the recording available
  • Webinar gated page submission now pushes to this page
  • Opens up GatedResourceLayout to account for different body for Recording pages
  • Updates GatedResourceLayout hero bg to new requirements

Test

  1. Ensure prettier has standardized the proposed changes.
  2. Nav to /webinars/code-insights-turning-your-metrics-into-action + ensure form submission brings the user to the recording page
  3. Nav to /webinars/code-insights-turning-your-metrics-into-action?watch-now and ensure page matches spec
  4. Ensure no breaking changes are coming into other components using the GatedResourceLayout:
  • /2022-gartner-cool-vendors-in-software-engineering
  • /guides/fixing-vulnerabilities-less-is-more
  • /guides/optimizing-developer-onboarding
  • /webinars/preparing-for-the-next-log4j

@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Jun 7, 2022

Notifying subscribers in CODENOTIFY files for diff 7b7a962...6b3a0e2.

Notify File(s)
@content-platform-team src/components/GatedResourceLayout/index.tsx
src/data/tracking.ts
src/hooks/hubSpot.ts
src/pages/2022-gartner-cool-vendors-in-software-engineering.tsx
src/pages/community.tsx
src/pages/webinars/code-insights-turning-your-metrics-into-action.tsx

@st0nebreaker st0nebreaker self-assigned this Jun 7, 2022
@st0nebreaker st0nebreaker added team/content-platform marketing-request Used by CPT to indicate requests from the Marketing Team labels Jun 7, 2022
@st0nebreaker st0nebreaker added this to the A - Sprint 6 milestone Jun 7, 2022
@st0nebreaker st0nebreaker requested review from zlonko and bretthayes June 7, 2022 18:36
Copy link
Contributor

@zlonko zlonko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Everything works as expected, and the previous pages were intact when I checked. Just a few minor notes!

zlonko
zlonko previously approved these changes Jun 8, 2022
Copy link
Contributor

@zlonko zlonko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look at those notes, Becca. This looks good to go!

portalId: '2762526',
formId: form.formId,
formId: form?.formId ?? '',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formId is always required if you're using the HubSpot hook so I don't think we should allow it to ever be optional. I see why you're allowing this now that I've looked at the rest of the code - more on this in further comments.

Suggested change
formId: form?.formId ?? '',
formId: form.formId,

@st0nebreaker st0nebreaker requested a review from zlonko June 9, 2022 14:33
zlonko
zlonko previously approved these changes Jun 9, 2022
Copy link
Contributor

@bretthayes bretthayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for consolidating this into a simpler solution to avoid dupe content! ✨

@st0nebreaker
Copy link
Contributor Author

This is ready for stakeholder review, @elzannewentzel ! Staging link to the video is here, webinar landing page is here (form submission taking the user to the video)

@st0nebreaker st0nebreaker merged commit fe3716d into main Jun 9, 2022
@st0nebreaker st0nebreaker deleted the feature/CI-webinar-rec branch June 9, 2022 19:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
marketing-request Used by CPT to indicate requests from the Marketing Team
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Gated page: Code insights webinar recording
4 participants