-
Notifications
You must be signed in to change notification settings - Fork 173
Conversation
Notifying subscribers in CODENOTIFY files for diff 7b7a962...6b3a0e2.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Everything works as expected, and the previous pages were intact when I checked. Just a few minor notes!
src/pages/webinars/code-insights-turning-your-metrics-into-action/index.tsx
Outdated
Show resolved
Hide resolved
src/pages/webinars/code-insights-turning-your-metrics-into-action/watch-now.tsx
Outdated
Show resolved
Hide resolved
src/pages/webinars/code-insights-turning-your-metrics-into-action/watch-now.tsx
Outdated
Show resolved
Hide resolved
…ion/watch-now.tsx Co-authored-by: Tim Zielonko <[email protected]>
… into feature/CI-webinar-rec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look at those notes, Becca. This looks good to go!
portalId: '2762526', | ||
formId: form.formId, | ||
formId: form?.formId ?? '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formId
is always required if you're using the HubSpot hook so I don't think we should allow it to ever be optional. I see why you're allowing this now that I've looked at the rest of the code - more on this in further comments.
formId: form?.formId ?? '', | |
formId: form.formId, |
src/pages/webinars/code-insights-turning-your-metrics-into-action/watch-now.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for consolidating this into a simpler solution to avoid dupe content! ✨
This is ready for stakeholder review, @elzannewentzel ! Staging link to the video is here, webinar landing page is here (form submission taking the user to the video) |
Closes #5412 by adding a
/watch-now
recording page for the Code Insights webinarChangelog
watch-now
sub-path to the Code Insights webinar page with the recording availableGatedResourceLayout
to account for different body for Recording pagesGatedResourceLayout
hero bg to new requirementsTest
/webinars/code-insights-turning-your-metrics-into-action
+ ensure form submission brings the user to the recording page/webinars/code-insights-turning-your-metrics-into-action?watch-now
and ensure page matches specGatedResourceLayout
:/2022-gartner-cool-vendors-in-software-engineering
/guides/fixing-vulnerabilities-less-is-more
/guides/optimizing-developer-onboarding
/webinars/preparing-for-the-next-log4j