This repository has been archived by the owner on Feb 21, 2025. It is now read-only.
Webinar Recording pg: Code Insights #5442
Merged
+194
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notifying subscribers in CODENOTIFY files for diff 7b7a962...6b3a0e2.
|
st0nebreaker
added
team/content-platform
marketing-request
zlonko
suggested changes
Jun 8, 2022
src/pages/webinars/code-insights-turning-your-metrics-into-action/index.tsx
Outdated
Show resolved
Hide resolved
src/pages/webinars/code-insights-turning-your-metrics-into-action/watch-now.tsx
Outdated
Show resolved
Hide resolved
src/pages/webinars/code-insights-turning-your-metrics-into-action/watch-now.tsx
Outdated
Show resolved
Hide resolved
…ion/watch-now.tsx Co-authored-by: Tim Zielonko <[email protected]>
… into feature/CI-webinar-rec
zlonko
previously approved these changes
Jun 8, 2022
bretthayes
suggested changes
Jun 8, 2022
| portalId: '2762526', | ||
| formId: form.formId, | ||
| formId: form?.formId ?? '', |
There was a problem hiding this comment.
The formId is always required if you're using the HubSpot hook so I don't think we should allow it to ever be optional. I see why you're allowing this now that I've looked at the rest of the code - more on this in further comments.
Suggested change
| formId: form?.formId ?? '', | |
| formId: form.formId, |
src/pages/webinars/code-insights-turning-your-metrics-into-action/watch-now.tsx
Outdated
Show resolved
Hide resolved
added 2 commits
June 8, 2022 14:31
zlonko
previously approved these changes
Jun 9, 2022
bretthayes
approved these changes
Jun 9, 2022
|
This is ready for stakeholder review, @elzannewentzel ! Staging link to the video is here, webinar landing page is here (form submission taking the user to the video) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5412 by adding a
/watch-nowrecording page for the Code Insights webinarChangelog
watch-nowsub-path to the Code Insights webinar page with the recording availableGatedResourceLayoutto account for different body for Recording pagesGatedResourceLayouthero bg to new requirementsTest
/webinars/code-insights-turning-your-metrics-into-action+ ensure form submission brings the user to the recording page/webinars/code-insights-turning-your-metrics-into-action?watch-nowand ensure page matches specGatedResourceLayout:/2022-gartner-cool-vendors-in-software-engineering/guides/fixing-vulnerabilities-less-is-more/guides/optimizing-developer-onboarding/webinars/preparing-for-the-next-log4j