-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for bringing in so many improvements here, from Tailwind preparations to accessibility considerations. I have just a few observations below.
Reviewing this PR helped me notice a few things to address in the Code Health PR. I think it would be helpful to have this merge first, so that I can pick up ThreeUpText
and the alt-text addition to BlogListItem
.
src/pages/use-cases/index.tsx
Outdated
<blockquote className="blockquote mt-8 px-6"> | ||
<p className="border-left-red pl-3 font-weight-bold"> | ||
“For our new developers, Sourcegraph has been invaluable to get to know the | ||
repository structure, to track down where code lives, and self-service during their | ||
investigations.” |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am just noticing that these are a similar pattern to BlockquoteWithBorder
. What do you think of using that component in these sections?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Except if we conform these to our BlockquoteWithBorder
they'll lose the bold and the side border length will be longer (past the author section). Do you think these are small enough differences we should still do it? Ss below, top is how it would change, bottom is what it is now. Cc: @bretthayes what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! It is helpful to see the contrast. I am okay with these differences if using components increases maintainability overall, but I defer to you and @bretthayes' judgment. We could also handle this in a separate issue if this is outside of scope here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I'd like to re-use components where possible. I applied that BlockquoteBorder
component to this page and refactored the rendering a bit. So it should be good now if there aren't any reservations!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the initial intent was to have a border against the quote itself, but with the border extending down towards the author, it creates more of a separation between the left side content and the blockquote. I would say this is a nice tradeoff to enable more code re-use. Funny that this is PR is for a page about code-reuse. 😆
We can also revisit this a bit more later cause I'm anticipating we'll have a blockquote refresh along with some other UI components. ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I'd prefer to have the border just by the quote, not the author. And we can have all quotes with the border conform to this. A blockquote refresh is needed I think!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Becca! Just a few revisions below. Might need to do a final pass with prettier as well. 🤓
src/pages/use-cases/index.tsx
Outdated
<blockquote className="blockquote mt-8 px-6"> | ||
<p className="border-left-red pl-3 font-weight-bold"> | ||
“For our new developers, Sourcegraph has been invaluable to get to know the | ||
repository structure, to track down where code lives, and self-service during their | ||
investigations.” |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the initial intent was to have a border against the quote itself, but with the border extending down towards the author, it creates more of a separation between the left side content and the blockquote. I would say this is a nice tradeoff to enable more code re-use. Funny that this is PR is for a page about code-reuse. 😆
We can also revisit this a bit more later cause I'm anticipating we'll have a blockquote refresh along with some other UI components. ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @st0nebraker! 💫
.border-3
with a note to trade it out with the relevant Tailwind class on migration