Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Port/new nutanix case study + new layout #103

Merged
merged 18 commits into from
Apr 12, 2022
Merged

Port/new nutanix case study + new layout #103

merged 18 commits into from
Apr 12, 2022

Conversation

st0nebreaker
Copy link
Contributor

@st0nebreaker st0nebreaker commented Apr 7, 2022 •
edited
Loading

Closes #68 . Ports over new Nutanix Case Study along with new Case Study Layout design with a few other re-usable sections to go with this design refresh. (PR#5232)

Test

Navigate to /case-studies/nutanix-fixed-log4j-with-sourcegraph

@st0nebreaker st0nebreaker requested a review from bretthayes April 7, 2022 21:03
@st0nebreaker st0nebreaker self-assigned this Apr 7, 2022
@st0nebreaker st0nebreaker added the team/content-platform Content Platform Team related tickets. label Apr 7, 2022
@st0nebreaker st0nebreaker added this to the AR - Sprint 1 milestone Apr 7, 2022
@st0nebreaker st0nebreaker changed the title Port/new nutanix case study Port/new nutanix case study + new layout Apr 7, 2022
bretthayes
bretthayes suggested changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@bretthayes bretthayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how these snuck in but it looks like you have some linting errors that need to be fixed. Maybe the pre-commit githook didn't run.

Run yarn lint and also yarn prettier for cleanup.

src/styles/_typography.scss Outdated Show resolved Hide resolved
@st0nebreaker st0nebreaker requested a review from bretthayes April 8, 2022 19:13
@st0nebreaker st0nebreaker marked this pull request as draft April 8, 2022 19:14
@st0nebreaker st0nebreaker marked this pull request as ready for review April 8, 2022 19:14
bretthayes
bretthayes suggested changes Apr 8, 2022
View reviewed changes
src/components/CaseStudies/CaseStudyCard.tsx Outdated Show resolved Hide resolved
src/styles/pages/__case_studies.scss Outdated Show resolved Hide resolved
src/components/CaseStudies/UseChallengeSolutionResults.tsx Outdated Show resolved Hide resolved
@st0nebreaker st0nebreaker requested a review from bretthayes April 8, 2022 22:17
@st0nebreaker st0nebreaker marked this pull request as draft April 8, 2022 22:18
@st0nebreaker st0nebreaker marked this pull request as ready for review April 8, 2022 22:18
bretthayes
bretthayes approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@bretthayes bretthayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just need to wait on sourcegraph/about#5209 to be closed

@bretthayes
Copy link
Contributor

Might have to run yarn prettier here as well

@st0nebreaker st0nebreaker merged commit b8af304 into main Apr 12, 2022
@st0nebreaker st0nebreaker deleted the port/new-nutanix-case-study branch April 12, 2022 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bretthayes bretthayes bretthayes approved these changes

Assignees

@st0nebreaker st0nebreaker

Labels
team/content-platform Content Platform Team related tickets.
Projects
No open projects
Content Platform Work
Status: Done ✅
Milestone
AR - Sprint 2
Development

Successfully merging this pull request may close these issues.

Nutanix Case Study - New Template to Re-Platform
2 participants
@st0nebreaker @bretthayes