refactor(core): ARC-69 ignore rest of sonar smells #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sf-sahil-jassal
force-pushed
the
gh-69
branch
from
8987464 to
c309ff2
Compare
yeshamavani
requested changes
Dec 14, 2023
src/redux/apiSlice.ts
Outdated
Comment on lines
37
to
38
| // eslint-disable-next-line no-console | ||
| console.log('sending refresh token....'); // NOSONAR |
There was a problem hiding this comment.
are these consoles really necessary
There was a problem hiding this comment.
This is not needed. This can be removed.
Comment on lines
+60
to
+61
| // eslint-disable-next-line no-console | ||
| console.log('Configuration file copied to public directory.'); // NOSONAR |
There was a problem hiding this comment.
This is only during the development, we can keep this.
Comment on lines
+54
to
+55
| // eslint-disable-next-line no-console | ||
| console.log('Configuration file written in current directory.'); // NOSONAR |
There was a problem hiding this comment.
Same for this this is only during development.
|
@Yogi-Vishwas are these consoles really required |
ignore sonar code smells related to unexpected console statments in handling errors
sf-sahil-jassal
force-pushed
the
gh-69
branch
from
c309ff2 to
d26c4b3
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore sonar code smells related to error handling consoles and unpredictable any types