Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Beta Docs “grain” #162

Merged
merged 3 commits into from
Aug 17, 2020
Merged

Update Beta Docs “grain” #162

merged 3 commits into from
Aug 17, 2020

Conversation

joiecousins
Copy link
Contributor

@joiecousins joiecousins commented Aug 11, 2020

Automatically generated by Netlify CMS

Paired with @KuraFire

Copy link
Member

@KuraFire KuraFire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through this version of the doc and continued building on it in conversation with @decentralion. I'm not sure what we ought to do with this PR as mine builds on it. Does it simply supersede this one, or do we need to merge this (#162) first and THEN I do my PR via Publish in Netlify? cc @HammadJ

@teamdandelion
Copy link
Contributor

@KuraFire if your PR builds on this one, then I recommend merging this one first, and then you can republish your changes on top, or fix it via git rebase if you're so inclined. that way @joiecousins will still get Cred for this review.

@KuraFire KuraFire merged commit ec46e34 into master Aug 17, 2020
@KuraFire KuraFire deleted the cms/beta/grain branch August 17, 2020 01:20
@KuraFire
Copy link
Member

That's exactly what I was thinking & hoping, perfect! Thank you @decentralion !

@KuraFire KuraFire mentioned this pull request Aug 17, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants