This repository has been archived by the owner on Aug 15, 2019. It is now read-only.
Generic arduino commands #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow commands to send one-off replies without neeing to pollute the global board 'status' with command-specific response information.
This includes passing them through to the arduino as well as wrapping the responses in common boilerplate for interpretation by robot-api.
PeterJCLaw
requested review from
prophile,
thomasleese,
Adimote and
kierdavis
robotd/devices.py
Outdated
|
|
||
|
|
||
| class InvalidResponse(ValueError): | ||
| """The servo assembly emitted an response which could not be processed.""" |
There was a problem hiding this comment.
bbf7ec9; thanks!
kierdavis
previously approved these changes
Jan 29, 2018
kierdavis
dismissed
their stale review
Having done some tested, I'm not so sure.
|
I'm confident that this works after testing on a kit yesterday. The uncertainty was actually due to issues with the arduino's firmware (sourcebots/arduino-fw#8, sourcebots/arduino-fw#9 and sourcebots/arduino-fw#11). |
kierdavis
approved these changes
Jan 30, 2018
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes an immediate-response mechanism (fd728d0), some tidyup (10c0525 & 97e4676) and then introduces a mechanism for handling and replying to generic commands (9e0049b & 4a68906).
We assume that anyone wanting to use this mechanism will implement their own commands in the firmware, following our existing conventions.