Skip to content
This repository has been archived by the owner on Oct 19, 2020. It is now read-only.

Update all dependencies to latest version #12

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Update all dependencies to latest version #12

merged 1 commit into from
Jun 28, 2019

Conversation

aminimalanimal
Copy link

@aminimalanimal aminimalanimal commented Jun 25, 2019

This PR updates all dependencies to their latest version, using yarn upgrade-interactive --latest.
It is a follow-up to PR 11, which didn't target the proper branch. (This branch was created from developer instead of master as well).

This is untested. I installed Docker and ran the commands mentioned under the Development section of the repo's README, but am unfamiliar with Docker and could not get a yarn link between projects to throw the errors I expected (even with only pug-lint updated, which properly threw errors for me yesterday when linking the master branches together).

Below is the original PR's description.

Update pug-lint to version 2.6.0 to resolve issue #7

This PR updates pug-lint-vue's pug-lint dependency to version 2.6.0 to fix Issue #7 (doesn't support v-bind shorthand).

pug-lint published version 2.6.0 today to fix this error by updating its pug-lexer dependency to 4.0.

I have yarn link 'ed pug-lint-vue to test it locally and can confirm that this dependency upgrade corrects the issue.

@aminimalanimal
Copy link
Author

When I run docker-compose up, I receive this output in the console:

Starting pug-lint-vue_app_1 ... done
Attaching to pug-lint-vue_app_1

It seems to hang there indefinitely. I started to wonder if I should open another console tab to run docker-compose exec app bash in it. When I did, I didn't really understand the results. Can someone enlighten me?

@pehbehbeh pehbehbeh merged commit 4d7aef5 into sourceboat:develop Jun 28, 2019
@pehbehbeh pehbehbeh self-assigned this Jun 28, 2019
@pehbehbeh pehbehbeh added this to the 0.3.0 milestone Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't support v-bind (and possibly v-on) shorthand
2 participants