Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dockerfile entrypoint and change dir before run artisan in entrypoint.sh #20

Merged
merged 4 commits into from
May 28, 2020
Merged

Fix Dockerfile entrypoint and change dir before run artisan in entrypoint.sh #20

merged 4 commits into from
May 28, 2020

Conversation

hingew
Copy link
Contributor

@hingew hingew commented May 28, 2020

This fix the Dockerfile entrypoint in the docker file. Bash is not not needed and causes an error. Docker runs the entrypoint default with sh -c.

In the entrypoint.sh the cd command is needed to run first, before the artisan command runs.

@hingew hingew added the bug Something isn't working label May 28, 2020
@pehbehbeh pehbehbeh added this to the Next Release milestone May 28, 2020
@pehbehbeh pehbehbeh merged commit 3191979 into develop May 28, 2020
@pehbehbeh pehbehbeh deleted the feature/fix-entrypoint-2 branch May 28, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pehbehbeh pehbehbeh

Labels
bug Something isn't working
Projects
None yet
Milestone
0.10.2
Development

Successfully merging this pull request may close these issues.
2 participants
@hingew @pehbehbeh