HackParser integration (#413)

* feat/wip: Add basic structure for getting signed S3 URLs

* test: Add PDF file input

* fix: Revert to older pnpm changes

* fix: Get the correct lock file version

* fix: Add pdf identifier to test

* fix: Remove updated Slack message for tests

* test: Add pdf uploading and fix tests

* test: Add putS3Object mock

* rix: Remove all the test requirements

* fix: Add example.pdf in app root as well

* fix: Add more pdfs everywhere

* test: Remove everything of practical use

* refactor: Add in slackbot pdfssssssssssssssssssssssssssssssssssss

* Update PDF downloading code, added debug log of response

Temporarily disable test coverage threshold

* Add tests for requesting reviews with a PDF

Re-enable testing threshold
Remove uncessary node-fetch

* Add PDF & files to updated message on review accept

Add logging of errors to console.

* Break text up into multiple blocks to avoid 3001 character limit

* Make HackParser integration togglable

Add error handling to HackParser integration
Fix edge case around code results block being added when there are just plain results
Add remaining tests
Revert getReviewByThreadId addition

* Cleanup test PDFs, restore coverage thresholds, cleanup comments

* Move HackParser specific logic into HackParserService

Improve cleanup of environment variable changes during testing

* Cleanup tests

Normalize style of requestReview test to reduce uncessary duplicate executions
Add assertion helper to acceptRequestReview
Remove duplicagte test from acceptRequestReview

* Add additional acceptReviewRequest error tests

* Bump line coverage coverage threshold

* Infer type from @smithy/type instead of using it directly

* Update presigned URL expiration to 7 days

---------

Co-authored-by: Charlie Hall <[email protected]>

.aws/bin/HackerRankQueue.ts

@@ -44,6 +44,7 @@ new HackerRankQueueStack(app, 'HackerRankQueueStack', {
     ENCRYPTED_GOOGLE_SERVICE_ACCOUNT_EMAIL: modeConfig.ENCRYPTED_GOOGLE_SERVICE_ACCOUNT_EMAIL,
     WORKDAY_START_HOUR: modeConfig.WORKDAY_START_HOUR,
     WORKDAY_END_HOUR: modeConfig.WORKDAY_END_HOUR,
+    HACK_PARSER_BUCKET_NAME: modeConfig.HACK_PARSER_BUCKET_NAME,
     TZ: 'America/Chicago',
   },
 });

.aws/cdk.json

@@ -13,7 +13,8 @@
       "ENCRYPTED_GOOGLE_PRIVATE_KEY": "AQICAHgmK7RLzJGLsX027nGL/3YoG67Jh4Mxgt5hOhZTg/kH0AHEr+SbFFY945kYFwnuo4kWAAAHEDCCBwwGCSqGSIb3DQEHBqCCBv0wggb5AgEAMIIG8gYJKoZIhvcNAQcBMB4GCWCGSAFlAwQBLjARBAxt2Sue9xubIZWoLekCARCAggbD0uwuAHJ3wCHirHsU90OweETVU4S+ek4jN6D0BH3xvRPLWLWBJredL3Ln7p4udHkYSsOYlSId/3TqeraNKjtoz+xdUnL5XE59OwIxC9qXzZu/E1WRLYKDcEthze4mWm+xlPgutYnZk6QQOLVE/HiMqK+4Xr0zfr0o9o8hOA9t6Z3ZIjb/Xea/AAg7Cnt0AikQW/TKj6ET470rfDHNbYHzF4tioj+PyebXICA+1xurWNHB9t0I3dzbe3BM0per3bzxjDUuCTh37JKd7+t+peH4hSs315TeWe2GLgFA/3stqcD6Fi6w1Ruo26RFwQn8DEhZc1i5x2CC0NRc76xoqYLhuMIjC+ZROE0XsuPCv6gmiVTTmrHDuLStTtsvcH7F7fesq2LZPvB/4Ox1qIR2+aU70Otuxemq047JaL/DPZUhG6n7QT61RvWsLaWfmsrfYcguO5d9mYzznJyApkzqUhDY9QcdAeq5HwZ2vSMlaVAWKcm8VuEfHfmyCpM8Y+sPLLwDEr2DiSkhKW72jz186zRagp9BLc/0ngWl2U+m1AtiCVQaTpwAwN+B6hrKgJklr1EyXRxyya8SHBsr7z/p6hEbo7SKYglteegsjwFeWfdZQkjdE5Tc5vwBpYBxQoXGCEvSrK1BZBRGi4bNr7X2+IjhdJ7ZVVK54TlWU5RUHlH08mPWtDdvZyVg4g3YtqFFmbRT7WVXhS0K6g3aZWJZ7vmbQT/GT3SoW30WOMy45KPP2mejc9ag7GEX+phoc8oySF4SJLPdlkHvvnLbXmKNboXgzCYsAlLMqU+zo/MO/bma3hB+o4EUpdfPGLMwWiRaKede7iEfW1ScCYgLySWE9ctdjU+FYTczcty6MzgYTlYKkGuz9v2OpVtbnhg+aWmMMRKMHOYCrgHyD83P5e8LifiSg45/VqbmmZJGuOcAuCr97cddJKUsat1PRPe5D3/INPOptV5TauJ8ArmAgJs2TkQADP4nSzmOPI8FJoD5BpYSKqNc6hY1NSJOs4SoEMPybmLQXA/4fpM5PogBFi7X3w16h2Idljp1YphKPe++JCNMpt1T9Bpz5GM9667jWectvrFzed3aBPaChKEGJ0J1rxljBWxlVMqswJu/ST0dtpdniiDTm6WGK2ECDs3QbZjfG19wVB/PM7qvB2R7KHfneoSNj4/+cmGte7xMbS7AurlYrrWhH+DwISQmgFWvQmr/z3JYFluLlwJSXm7WUHHNgm3Cjgo5O73nRSv8R8PhRR5srP3Ore8PnpUNAfIP9+N3jJqj3cX5joBKbZa/FIvSbikH5FsDUs3OlXbquSDuvjir3EljiN5R5CWM9soWLP3n5/hK47Ki4YvQTEAJbdg1enaFPHN8P4JVLRlbUyjlNPNReuESDlAP20qcbi/dx2rSl3kRphDNvljgWmPHHbovae+6aSJFKSIZ6uUThtGQcxpaEoD4hSQmwX2DDUU35xbOqftLqTN5dhmgldcf9y3L2br0+IgX/8Iddhw+xDHJE+vOJSuzz5K9DJka4D06zs5glCECIoowjPJv6K9ykFAf/Fdm8bN7cqblo6I/oWpFJieBoUUPkr4Y1IjGxohp2rlq4CpaEtuOT7UDdlcmnKbToKl4se9IrOLZ02GDDLRBLqFerJBDZPYKVqj40wQnQqsD35kaZC/ZenhBL8pcDW6gT/JoRdgP22XAQS0lBvOH5JeI0SrPmu07auDS3EFBCWx0Js1ylXDIKzdSvtOFixnYk/Etv/eWeF6HULlUQAQxWvjPT+ouKJzQ4Jl5oFp79iplDeuGfbx7McUrVjgZTPAc2B8ke9AMj4L5NJa0eba8As8uXLEYvR4+TyTeqXchQbQ2K5e4VQu9e47CkD8CmmtmVRS9FBKSJgrKs0+FlDuiZ7aX3mtYmLl2C5R5xR+YxOrgJD0i0VlxXDW2Yj2XyPIy49aL/8ShI+zkcLFIPLJ3YsCa3/hHQp7bcEZcRukWd/OpOWYQcNsq9H+rsZ9tXLoBHpMd1vZXk0o22ZGma8oAVasTO/CcJEQY5tP0m5jDM8wwO+OB87UzHCqD52IUdWXYIM1CMv0Z9BxTy7sG6ZA2Yw8evcsYclH/XSAsDkPJtOUUA53rSTrMUoUyem+QB0bIyZYMqFY9QNGj+ExiyWaR/x05mwqb7ShdZk3LP1RCkvHYZK0lFcTHfqilHRZO5foUdubMPNuIbB/FGpYlCUXvKDwcbPTqISmpz8qW2VjEJvj0rnzHpC/DaqjdharMv4AK59Fae2AW99WKb8rVxQKFezXtaEMtQnfMViqfW0H85HxOu0z6lcFz",
       "ENCRYPTED_GOOGLE_SERVICE_ACCOUNT_EMAIL": "AQICAHgmK7RLzJGLsX027nGL/3YoG67Jh4Mxgt5hOhZTg/kH0AEaRVPWlX2aVKL8w/25FRmuAAAAlDCBkQYJKoZIhvcNAQcGoIGDMIGAAgEAMHsGCSqGSIb3DQEHATAeBglghkgBZQMEAS4wEQQMKzMqXyLoCKEizJLXAgEQgE6KG7oJcvvJDkhnvxOR5Z2blZ0UH/ib7FTXBaDDQUASqASjyQhOyIVB+V7boljYMTgVhcUWZprkgMvS2hFbiS7gaRlC59KLgkPFP5+VmaE=",
       "WORKDAY_START_HOUR": "8",
-      "WORKDAY_END_HOUR": "17"
+      "WORKDAY_END_HOUR": "17",
+      "HACK_PARSER_BUCKET_NAME": "hack-parser-dev"
     },
     "prod": {
       "HOSTED_ZONE": "sourceallies.com",
@@ -27,7 +28,8 @@
       "ENCRYPTED_GOOGLE_PRIVATE_KEY": "AQICAHj0rd9+A15pncr1JrWCjeFtR4hrNnZnqKAX0mW97lZXPAGSmRSjKiVg8BK+dJI5+inyAAAHEDCCBwwGCSqGSIb3DQEHBqCCBv0wggb5AgEAMIIG8gYJKoZIhvcNAQcBMB4GCWCGSAFlAwQBLjARBAzL+UWBA1gxZvqw4mICARCAggbDxMNnEwEi/dV4QJsCaN4LV6w1nppiKBMtlhIIuBBTzrYBCRmhoIipbFrjZptLp+E4KCWSYdbxz1sOCrH0ZMGThm/GQinZoQW0X9cJQJOn/XFnb6d7G3Oa3J82Fbf0U4wV6O57JaE8xOhocC84knER1a0HTXU3419oJro9DGtqvoO1j0CahGs0aS0EEcgRCpOJJ20i7cDicmIIS/PMzY+CJhDO1zBHufdeGUnf/PQKCOXN9Ua2DI194cYcxk6YOXraHVaZ3xMYift3FdXs7b2aBkDQqhidffzIJ1AB7WgkKEk0dWguwN9shCu56nVpT2qaac3wmJicijyhbkyn+oDllTv9oFC9SuR4CcDM/1IpwEZG1SHREm/R2y8TMuwAVD+zSf5Sdq7OwCwImoIyZ3Wazv18dwHYeP6oIxYX+b+MP+Dy7RNZqDVAL6sB9dNvC2+ZuJ80I/BzYYOnJ530VqSLhLE7oei7is3VQ3IO2AqTZ8BJkZ1eSQFMgfFYF5ZqcW92LkT6X9Fuy/B54uMXJgqGgrDmuPBB2SxbXNEbGuW0kfXGEGkqXbmNgN0o/hSthgOLCRXgWDBSp6vCRQD9y1WR7tx/y2DB6LH4gmGRNOp8a1eOheGyb1dxBJ705/6qTa7MOHduP9qUIoFFqCsX00FcnBe5SeCo1UuB85z/M5QOBJlYrNjjbkJYgzJouFeerOzhmTHavuluTT1KfVw+oWaGBnRl7xmbDGNZCqmQh+YbZJv6Y6VxoJYgPaxVn1VOx5lNJ9FnO3tf9HBtp7hVxEnczg6T1LYxyVVYNrtaw4TyY6sTNLtP6K5zLWFcizqhidvV25y/Q9YRzzZULbXNYy0wC8jOUk3P5QniWHeOOb74eGPcuJkdV72l3Fgwm9SqKb0xlPmZFQQxP0/h+MdOq10gAdFFbyYCiimUvywLaAHBQ9j66iOE/woOsxjuYqr3XfmLlTuwK1sBothlo0la+9PL3M/3VOZ49Ber6HlY3Fovvv2gtIF08DTZCGvcuZuf0OvV1/RFK3YfsBPBEmiD77e4VJUJ4+D6wr541iu6RfEebHAhzMSwe3z2Ev9O+vNCiBSXYBGAtSj3XhtHokyJ+t7K1RL+mN4tD5mKz5zwJDf6VJEj09IyDo6HOdOfSGKObgocueqHSU04V1mOCZxLwaKRdzFRLn5wIsgc6ieV6ldV1r/oNO4mzlWj9v+XIS4i+BXYS7fdGJKucG90r+huWx0QAS0Nlb249M5OMsubbniKUFI828pClQZ+HFE1W/0dR5sc1yFhX7pHdQTtekdWEWa1vzoWKuIwlrw/V153JumTYJ9hSE6cWCL3auVWJlQKOsqnJanwAjzIaX7s2pWEEJu8gPuvnC7WyMCCUSA+5tAcnXO7WgRWn2jpCF3KCHJaRmDYmtsjlfW2x1CT6Q2In8DjBgvf7sgk++9QgqsyLJ71HzbkGcBQ9h+g/6938jQXK3Dw4J3QbZYUoWAGyVp7f5yZonnokZNxo+DAzyzW3aE4YlUlzlPQRAu2LOp3mYXnRw4NqQ4gam092Yl4VVfg5bY+e7VWnqgeLqbQWjnOGvRtZ6j4bw1kgvTcnD9hm9TsDANdKyRSch6jv8cTd7K1Aqui9KHucm8kPl5tmJElomW2F0EFu2EHYQLPkKr1SIAKjzF3MvvPBp/A15rc0wJ7E51FrS+BiqUujUu1exh1kjTfa5GIA6V+sneOPwOOQvpsBx9NFsmWwX7kKwuAa5v2mxT4e3EYtTi6TfqX1Iyb7El3DEQJ6+7FWdO0bKWLIk0cmvBQq9mf57HFCLh/M70/t8+NfgV6yOEVFIPqDa/koZAqBugckFqGlyMew/1BL7qcqAEGcqP3t5AuDVjMavbDkBuIcNxIjnrQOZphDWFerqzJm+ulbYMs17EErJVXwt2bi2jYoGsFM9yitek1FqkzNGzq4ngA9xATrja0baAkG6ghooiCxJDBLdVcGtwUt+fm+yjQGDNAK6WWLlD8tTN98t11kgf0nTmTGI+CEfKHZMMFKnx1371B4NB/64wGYdTy7c9AUHR5KR0oZ4OmcKSsm6u0cBqesfuLFu/kL27gCbpMXQrBQ/qTsRmLljZWndUkHHyoMYLjZXmWOz5w47AobAPgG9MXlzN/WclZgNnrfAmUPUETWgjTwFMsu1n2Xi96zSYxF6vMHCQCFXfthEgEsgst81zbQTW24RGzawtZpVu8AXxWSvKOSH7WDQeOmx2wvqq74KR7s+4c3L6PMgkp55IvqOncgaD8hzgM+UnDZXYpt1N3GsJYbY6V6wgGCs+/VwSbvAVx",
       "ENCRYPTED_GOOGLE_SERVICE_ACCOUNT_EMAIL": "AQICAHj0rd9+A15pncr1JrWCjeFtR4hrNnZnqKAX0mW97lZXPAGr0HRhl9Anq+UoyGhRYnZbAAAAlDCBkQYJKoZIhvcNAQcGoIGDMIGAAgEAMHsGCSqGSIb3DQEHATAeBglghkgBZQMEAS4wEQQMHkGZcyEuoE5kdC9CAgEQgE5bFFe7hRWHrVDO9J90X2izrLD8fbLGAzU0gHtoSQwHvfg6YxEgpu5R4bnEH61AgkjkhsSKndMtyjZWnvc2yT+cRPFX8THuOiwt4zKtm+Y=",
       "WORKDAY_START_HOUR": "8",
-      "WORKDAY_END_HOUR": "17"
+      "WORKDAY_END_HOUR": "17",
+      "HACK_PARSER_BUCKET_NAME": ""
     }
   }
 }

.aws/lib/HackerRankQueueStack.ts

@@ -26,6 +26,7 @@ interface HackerRankQueueStackProps extends StackProps {
     ENCRYPTED_GOOGLE_SERVICE_ACCOUNT_EMAIL: string;
     WORKDAY_START_HOUR: string;
     WORKDAY_END_HOUR: string;
+    HACK_PARSER_BUCKET_NAME: string;
     TZ: string;
   };
 }

README.md

@@ -66,6 +66,8 @@ On feature branches, don't worry about doing conventional commits. Instead, just
    ```
 
    - `INTERVIEWING_CHANNEL_ID`, `ERRORS_CHANNEL_ID`, and `SPREADSHEET_ID` can be found in [`cdk.json`](.aws/cdk.json)
+   - `HACK_PARSER_BUCKET_NAME` can be found in [`cdk.json`](.aws/cdk.json)
+     - If provided as an empty string, the [HackParser](https://github.com/sourceallies/hack-parser) integration will be disabled.
    - `SLACK_BOT_TOKEN`, `SLACK_SIGNING_SECRET`, `GOOGLE_SERVICE_ACCOUNT_EMAIL`, and `GOOGLE_PRIVATE_KEY` come from AWS Secrets Manager
    - The `GOOGLE_PRIVATE_KEY` multi-line variable needs to be turned into a single line wrapped in quotes.
      - `GOOGLE_PRIVATE_KEY="-----BEGIN PRIVATE KEY-----\nMIIEvQ\n-----END PRIVATE KEY-----"`

jest.config.js

@@ -15,10 +15,10 @@ module.exports = {
   coverageDirectory: 'coverage',
   coverageThreshold: {
     global: {
-      branches: 50,
-      functions: 70,
-      lines: 75,
-      statements: 70,
+      branches: 55,
+      functions: 75,
+      lines: 80,
+      statements: 75,
     },
   },
   coveragePathIgnorePatterns: ['src/utils/log.ts'],

package.json

@@ -27,14 +27,14 @@
     "preinstall": "npx only-allow pnpm"
   },
   "devDependencies": {
+    "@slack/types": "2.12.0",
     "@types/chance": "1.1.6",
     "@types/google-spreadsheet": "3.3.2",
     "@types/jest": "29.5.12",
     "@types/node": "18.19.34",
     "@types/node-cron": "3.0.11",
     "@typescript-eslint/eslint-plugin": "6.21.0",
     "@typescript-eslint/parser": "6.21.0",
-    "@slack/types": "2.12.0",
     "chance": "1.1.11",
     "eslint": "8.57.0",
     "eslint-plugin-only-warn": "1.1.0",
@@ -47,6 +47,8 @@
     "typescript": "5.4.5"
   },
   "dependencies": {
+    "@aws-sdk/client-s3": "^3.665.0",
+    "@aws-sdk/s3-request-presigner": "^3.665.0",
     "@slack/bolt": "3.18.0",
     "dotenv": "16.4.5",
     "google-spreadsheet": "3.3.0",