-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auction Modules and Base Implementation #18
Conversation
…Vectorized/sound-protocol into vectorized/pro-220-auction-base
🦋 Changeset detectedLatest commit: bf75d88 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PRO-220 Auction module interface and base implementation
First goal: should be compatible with our existing formats (see buy edition)
Compare delegate call vs pure extension options and write out a doc. We will discuss + get some input on the path forwards. Tradeoffs in terms of security, flexibility, provenenance/tx history, etc. |
Co-authored-by: Matt Masurka <[email protected]>
Co-authored-by: Matt Masurka <[email protected]>
Co-authored-by: Matt Masurka <[email protected]>
Co-authored-by: Matt Masurka <[email protected]>
Co-authored-by: Matt Masurka <[email protected]>
Closed #4, and replace with this PR instead.
Terminology:
Minter contracts are current non-upgradeable (will change later if needed).
Actually, we don't need to make these Minting contracts upgradeable.
Flow:
createEdition
on a Minter contract.mint
function on the Minter contract, which will then call themint
function on theedition
, passing along themsg.value
.Details:
So, instead of having the public auction and the permissioned auction combined, we split them into two different files.
If we want, we can add a combined public and permissioned auction like ArtistV6.
createEdition
anddeleteEdition
functions on theMinter
contract. Do we need functions to edit each of the fields individually? This will add quite a bit of work.