Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: install foundry in lint ci #14

Merged
merged 1 commit into from
Jul 21, 2022
Merged

ci: install foundry in lint ci #14

merged 1 commit into from
Jul 21, 2022

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Jul 21, 2022

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2022

⚠️ No Changeset found

Latest commit: 19a0064

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@saihaj saihaj added the approved-no-changeset Changeset is not needed label Jul 21, 2022
@saihaj saihaj merged commit 91c03a5 into master Jul 21, 2022
@saihaj saihaj deleted the saihaj/fix-ci branch July 21, 2022 16:18
mechanical-turk
mechanical-turk reviewed Jul 21, 2022
View reviewed changes
.github/workflows/lint.yml
@@ -16,6 +16,11 @@ jobs:
- name: Check out Git repository
uses: actions/checkout@v3

- name: Install Foundry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saihaj why install foundry inside the linting job? do we need it for linting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mechanical-turk mechanical-turk mechanical-turk left review comments

@gigamesh gigamesh gigamesh approved these changes

@elenadimitrova elenadimitrova Awaiting requested review from elenadimitrova

Assignees
No one assigned
Labels
approved-no-changeset Changeset is not needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saihaj @mechanical-turk @gigamesh