[fix] 모델적합도 다중반환 버그 수정 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sominyun
reviewed
Mar 8, 2024
| @@ -22,5 +22,7 @@ public interface ProductModelRepository extends JpaRepository<ProductModel, Long | |||
| + "ORDER BY p.searchTime DESC") | |||
| List<RecentModelResponse> getRecentModels(@Param("productId") Long productId); | |||
|
|
|||
| Optional<ProductModel> findByProductAndModel(Product product, Model model); | |||
| // Optional<ProductModel> findByProductAndModel(Product product, Model model); | |||
| ProductModel findTopByProductAndModelOrderByIdDesc(Product product, Model model); | |||
There was a problem hiding this comment.
궁금해서 그러는데 어떤 에러가 나서 이렇게 변경한거고 이렇게 하면 어떻게 결과가 나오는거야????
There was a problem hiding this comment.
@sominyun
우리가 productModel을 조회할때마다 쌓는 방식이잖아
그래서 product와 model이 같은데 searchTime만 다른 여러개의 row가 계속 쌓여
findByProductAndModel으로 jpa메서드를 사용하면 product와Model이 같은 여러개의 결과가 반환돼
Optional<ProductModel>은 null 또는 1개의 결과가 있어야 하는데 여러개의 결과를 찾으니 List<>형태로 jpa가 찾아 준거야.
그래서 에러가 났던거고, findTopBy를 사용하면 sql에 limit 1을 붙인거랑 같아. 하나의 결과만 반환하도록 보장해주는거야!
거시적으로 보면 ProductModel에 데이터를 계속 쌓는 방식이 안좋은 방식인 것 같아 ㅋㅋㅋㅋ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗃 Issue
🔥 Task
📄 Reference