최근 조회한 모델,모델 추천 API 추가 + swagger 문서 수정 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/#20-model # Conflicts: # src/main/java/com/backend/soullive_a/controller/ModelController.java # src/main/java/com/backend/soullive_a/service/ModelService.java
lsm-del
changed the title
sominyun
reviewed
Mar 7, 2024
|
|
||
| @Operation(summary = "모델 추천 API", description = "모델을 추천 받는 API이다.") | ||
| @GetMapping("/recommendation") | ||
| public BaseResponse<List<ModelRecommendResponse>> getRecommendModel(){ |
There was a problem hiding this comment.
“/recommendation/singer" 를 하면 가수 리스트가 반환되도록 하는 식으로
가수, 배우, 유튜버로 나누는게 좋아보여요
There was a problem hiding this comment.
그러면 API를 3개를 만들어야 하는데 job이라는 구분자로 구분하는 경우에 비해 장점이 어떤 것이 있는지 궁금합니다!
There was a problem hiding this comment.
지금 job이라는 구분자로 하나의 api에서 쓰고 있는게 아니라 이 api는 모든 모델을 반환하는 api 아닌가요..?
모델을 다 반환하면 프론트에서 직업에 따라 구분해서 리스트를 만들고 그 리스트를 이용해서 값을 넣어야합니다 그러기 위해서 프론트에서 15명이 있는 리스트를 직업별로 나누는 로직을 만들어어하는데 그건 프론트의 역할이 아니고 백이 데이터를 구분해서 주어야한다고 봐요..!
만약에 api를 한개쓰고 싶은거라면 @RequestParam 을 쓰거나 “api/recommendation/ {job}" 로 해서 직업별로 구분하되 input 값을 프론트와 일치시켜서 singer,actor,idol 로만 입력을 받을 수 있게 해야할 것같아요
| String modelName, | ||
| @Schema(name = "aiRate", example = "3.0", description = "ai 추천 점수입니다.") | ||
| Float aiRate | ||
| ) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗃 Issue
🔥 Task
📄 Reference