Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] 모델 화제성 조회 api #26
[feat] 모델 화제성 조회 api #26
Changes from all commits
755dc3d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저는 dto에서 id를 전부 다 뺐는데, 있는게 좋을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
세개 리뷰가 다 같은 내용이라 한번에 쓰자면 프론트에서는 사실 쓰는 값은 아니지만, 값을 잘 받아온건지 확인하는 용도로 쓰는 거라 편한대로 하는게 좋을것같아요. 저는 모든 dto에 id를 넣는편입니다..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
생각해보니까 바꾸는게 나을것같기도 하네요... 바꿔볼게요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ModelPopularityModelModelName 이게 상당히 어렵네.
ModelPopularity 필드의 model필드의 modelname를 가져오는거야?
그렇다면 엔티티끼리 join하는건 jpa에서 해주는건가?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
맞아요 jpa가 알아서 찾아주는거
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
같은 테이블에 삽입할 때는
이런식으로 줄이면 좋을 것 같아!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
근데 만약에 이렇게 하면 예를 들어 우리 모델을 15명 넣으면 줄이 오른쪽으로 계속 늘어나는 건가?