Updating to Python 3 and upgrading login to use OAuth #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolving conflicts with Python 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated login process to use
oauth_logininstead of oflogin(which has been marked deprecated).Since Python 2 is no longer supported by
gmusicapi, I made the minimum number of changes to get the code running on Python 3. Kudos for thelogfunction. That made it really easy to switch over.Not sure what the intent behind line 71 of
common.pywas:sys.stdout.write(message.encode(sys.stdout.encoding, errors='replace'))I replaced it with a simple print statement.
Tested by downloading and uploading a playlist.