Bunch of usability improvements, some bug fixes and functional enhancements #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for these scripts! I found them quite useful and I was glad not to have to write them from scratch myself!
I'm submitting some changes which I believe are improvements. I've tried to isolate them logically in separate commits.
The only change I'm unsure about is 583f17c. Your code uses the "storeId" field, if it is returned by the API, rather than the "id" field. I found that none of the songs for which the API returned a "storeId" were actually being added to my playlists. When I modified the code to always use "id", all of those songs were imported properly into my playlists.
Since I don't understand the API or your usage of it well enough to understand why "storeId" was being used in your code, I don't know what the global ramifications of my change are. All I know is that, for me at least, the import worked properly without "storeId", and improperly with it.
I've mentioned this change first because as I said it's the one change I can't say for certain is correct. Here are the other changes, which I'm much more confident about: