Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a delay before harness.io webhook #21

Merged
merged 1 commit into from
May 29, 2018
Merged

Add a delay before harness.io webhook #21

merged 1 commit into from
May 29, 2018

Conversation

bronxct1
Copy link
Contributor

Jira Ticket(s)

Description

  • adds a sleep command when WEBHOOK_DELAY_TIME env variable is present

Risk/Impact Analysis

  • This could cause temporary build up and increased wait time. Harness.io is working on a feature update that will remove the need for this delay.

QA Notes

N/A

@bronxct1 bronxct1 requested a review from marksost May 25, 2018 18:05
@bronxct1 bronxct1 force-pushed the feature/add-webhook-delay branch from 44c125f to 45f297e Compare May 25, 2018 18:06
marksost
marksost approved these changes May 29, 2018
View reviewed changes
Copy link
Contributor

@marksost marksost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

@marksost marksost merged commit 6796c28 into master May 29, 2018
@marksost marksost deleted the feature/add-webhook-delay branch May 29, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donofriov donofriov donofriov approved these changes

@marksost marksost marksost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bronxct1 @marksost @donofriov