chore: fix ci for ubuntu 24 and windows #2524
Merged
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quentin
force-pushed
the
ubuntu24build
branch
from
d57c5c9 to
42d69ee
Compare
We used to install package `sqlite` before ubuntu 24. Starting from ubuntu 24, the right package name is `sqlite3`.
Since the switch to ubuntu 24, some errors appear in the code coverage capture. Other projects have identified the same issue. For the moment, we simply discard the error.
Windows ci runners already `cmake` installed, so I remove it from the Chocolatey config file to avoid a conflict error.
quentin
force-pushed
the
ubuntu24build
branch
from
42d69ee to
565ca63
Compare
quentin
force-pushed
the
ubuntu24build
branch
from
5e79ce3 to
ae87a22
Compare
quentin
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2524 +/- ##
=======================================
Coverage 81.09% 81.10%
=======================================
Files 492 492
Lines 33361 33364 +3
=======================================
+ Hits 27055 27059 +4
+ Misses 6306 6305 -1 |
julienhenry
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI build on
ubuntu-latest(24) fails with missing dependencysqlite: https://github.com/souffle-lang/souffle/actions/runs/12881721601/job/35912754336#step:4:41Now use package
sqlite3.