Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: integer overflow in Complexity analysis #2509

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

quentin
Copy link
Member

@quentin quentin commented Sep 2, 2024

Avoid overflow by saturation of complexity.

fixes #2508

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.10%. Comparing base (e6cc668) to head (74ba385).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/ram/analysis/Complexity.cpp 93.75% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2509      +/-   ##
==========================================
+ Coverage   81.05%   81.10%   +0.04%     
==========================================
  Files         492      492              
  Lines       30922    30934      +12     
==========================================
+ Hits        25065    25090      +25     
+ Misses       5857     5844      -13     
Files with missing lines Coverage Δ
src/ram/analysis/Complexity.cpp 97.36% <93.75%> (-2.64%) ⬇️

... and 4 files with indirect coverage changes

@quentin quentin merged commit 437f280 into souffle-lang:master Sep 4, 2024
35 checks passed
@quentin quentin deleted the fix-2508 branch September 4, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discriminants/variant numbers are checked too late, causing assertion violations in user-defined functor
2 participants