fix apply on user-defined aggregate init
#2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `init` expression of user-define aggregates was never handed-over to `apply`'s `mapper`. One visible issue is that the `TupleId` transformer would not update the tuple of the `init` expression while shuffling tuple identifiers. That would then result in the `init` expression peeking data in the wrong tuple during execution of the RAM program.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2456 +/- ##
==========================================
- Coverage 78.19% 78.15% -0.04%
==========================================
Files 486 486
Lines 32374 32379 +5
==========================================
- Hits 25315 25306 -9
- Misses 7059 7073 +14
|
julienhenry
approved these changes
Dec 19, 2023
quentin
added a commit
to quentin/souffle
that referenced
this pull request
Jun 19, 2024
The `init` expression of user-define aggregates was never handed-over to `apply`'s `mapper`. One visible issue is that the `TupleId` transformer would not update the tuple of the `init` expression while shuffling tuple identifiers. That would then result in the `init` expression peeking data in the wrong tuple during execution of the RAM program.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
initexpression of user-define aggregates was never handed-over toapply'smapper.One visible issue is that the
TupleIdtransformer would not update the tuple of theinitexpression while shuffling tuple identifiers. That would then result in theinitexpression peeking data in the wrong tuple during execution of the RAM program.