Fix generated code for eqrel when emitting statistics #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! You just need to reformat the code. |
When using `--emit-statistics` for an `eqrel`, the generated code contains compilation error when accessing the indices. This was due to eqrel index is accessed via `ind` instead of `ind_*`, and this commit fixes the issue and adds a test case. Co-authored-by: Sandro Stucki <[email protected]>
fangyi-zhou
force-pushed
the
fix-eqrel-emit-statistics
branch
from
f5c3da7
to
2f10333
Compare
|
Reformatted as requested. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2419 +/- ##
==========================================
+ Coverage 77.75% 77.90% +0.14%
==========================================
Files 474 479 +5
Lines 31164 31397 +233
==========================================
+ Hits 24232 24459 +227
- Misses 6932 6938 +6
|
quentin
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
--emit-statisticsfor aneqrel, the generated code contains compilation error when accessing the indices. This was due to eqrel index is accessed viaindinstead ofind_*, and this commit fixes the issue and adds a test case.