Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "variable only occurs once" checker #2415

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Conversation

quentin
Copy link
Member

@quentin quentin commented Jun 12, 2023

Fix variable only occurs once checker:

  • deterministic source location
  • handle multi-head rules properly
  • do not report ungrounded variables (already reported by another check)

Still not handling properly the variables in negated conjunctions and aggregates.

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #2415 (12a8abe) into master (2914f7b) will increase coverage by 0.04%.
The diff coverage is 81.46%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2415      +/-   ##
==========================================
+ Coverage   77.75%   77.79%   +0.04%     
==========================================
  Files         474      479       +5     
  Lines       31164    31391     +227     
==========================================
+ Hits        24232    24422     +190     
- Misses       6932     6969      +37     
Impacted Files Coverage Δ
src/ast/analysis/typesystem/Type.cpp 47.37% <0.00%> (-0.47%) ⬇️
src/ast/analysis/typesystem/Type.h 50.00% <ø> (ø)
...c/ast/analysis/typesystem/TypeConstrainsAnalysis.h 100.00% <ø> (ø)
src/ast2ram/seminaive/ValueTranslator.h 100.00% <ø> (ø)
src/ast2ram/utility/TranslatorContext.h 100.00% <ø> (ø)
src/include/souffle/utility/SubProcess.h 55.00% <0.00%> (ø)
src/interpreter/Node.h 96.95% <ø> (ø)
src/ram/Variable.h 45.45% <45.45%> (ø)
src/ram/Assign.h 50.00% <50.00%> (ø)
src/parser/parser.yy 93.85% <58.33%> (-1.30%) ⬇️
... and 22 more

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants