fix sqlite reading of empty values #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like Github infrastructure was ill when the tests started. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2412 +/- ##
==========================================
+ Coverage 77.75% 77.76% +0.01%
==========================================
Files 474 474
Lines 31164 31164
==========================================
+ Hits 24232 24236 +4
+ Misses 6932 6928 -4
|
quentin
approved these changes
Oct 7, 2023
| @@ -66,12 +66,12 @@ class ReadStreamSQLite : public ReadStream { | |||
| for (column = 0; column < arity; column++) { | |||
| std::string element; | |||
| if (0 == sqlite3_column_bytes(selectStatement, column)) { | |||
| element = "n/a"; | |||
| element = ""; | |||
There was a problem hiding this comment.
What if it's a numerical column with a NULL value? What is the behavior before and after this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2411