-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typecheck error on atom negation with equivalent type #2399
Fix typecheck error on atom negation with equivalent type #2399
Conversation
Locally I have some tests that fails but it looks like it comes from my gcc distribution:
The tests are failing due to preprocessing errors on |
tests/syntactic/equivalent_types_in_negation/equivalent_types_in_negation.dl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. This fix deserves to be part of 2.4 release that is coming soon.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2399 +/- ##
==========================================
+ Coverage 77.56% 77.64% +0.08%
==========================================
Files 467 472 +5
Lines 30785 31042 +257
==========================================
+ Hits 23877 24102 +225
- Misses 6908 6940 +32
|
When type checking atom negation, equivalent types were not taken into account. Now they are.
I've added the reproduction test in
tests/syntactic/equivalent_types_in_negation/equivalent_types_in_negation.dl
.Fixes #2398