Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated JavaScript in profiles #2388

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Conversation

ruricolist
Copy link
Contributor

This fixes several bugs in the JavaScript generate for HTML profiles:

  • Charts would not be shown at all if code were not available.
  • "Graph iterations of selected" did not work on relations because the relevant code was using the wrong index.
  • The "Go back" button did not work (calling a goBack function deleted in c6d2b2d).

@ruricolist ruricolist changed the title Fix generated JavaScript Fix generated JavaScript in profiles Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #2388 (0334b07) into master (5b42c1e) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2388      +/-   ##
==========================================
+ Coverage   77.54%   77.56%   +0.01%     
==========================================
  Files         467      467              
  Lines       30785    30785              
==========================================
+ Hits        23871    23877       +6     
+ Misses       6914     6908       -6     
Impacted Files Coverage Δ
src/include/souffle/utility/ParallelUtil.h 84.49% <0.00%> (-0.78%) ⬇️
src/include/souffle/datastructure/BTree.h 98.33% <0.00%> (+0.41%) ⬆️
src/include/souffle/profile/ProfileEvent.h 98.00% <0.00%> (+5.00%) ⬆️

Copy link
Member

@quentin quentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.
I guess we have no way to automate tests on the profile pages.

@quentin quentin merged commit 4ee37c0 into souffle-lang:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants