Fix complexity analysis #2380
Merged
Fix complexity analysis #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2380 +/- ##
=======================================
Coverage 77.53% 77.54%
=======================================
Files 467 467
Lines 30779 30785 +6
=======================================
+ Hits 23864 23871 +7
+ Misses 6915 6914 -1
|
|
If I understand the problem correctly, the optimizer was not considering the dependence between branch check and functor call. And the fix is to give functor call a larger complexity. If so, can we give it an INT_MAX to make it clear that we want functor calls to be put at last? |
|
I agree, the current fix is not sufficient in some situations and associating the maximum complexity rank to functor call should solve the issue entirely. |
XiaowenHu96
requested changes
Jan 9, 2023
| @@ -62,7 +62,7 @@ int ComplexityAnalysis::getComplexity(const Node* node) const { | |||
| } | |||
|
|
|||
| int visit_(type_identity<UserDefinedOperator>, const UserDefinedOperator&) override { | |||
| return 10; | |||
There was a problem hiding this comment.
As per the comment, make it the maximum value of Int.
The complexity analysis was ignoring intrinsics operations that can contain functor calls. It had an impact on the reordering of conditions that would move a functor call too early when it is within an intrinsic operation. fix souffle-lang#2373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The complexity analysis was ignoring intrinsics operations that can contain functor calls. It had an impact on the reordering of conditions that would move a functor call too early when it is within an intrinsic operation.
fix #2373