Eliminate nondeterminism in Condition ordering #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditions were sorted nondeterministically in during both the MakeIndex and ReorderConditions RAM transforms. This updates both to use std::stable_sort and eliminates use of pointer comparison to sort Conditions.
adamjseitz
force-pushed
the
condition-order-determinism
branch
from
7fc4fe1
to
87c7e4f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2378 +/- ##
=======================================
Coverage 77.52% 77.53%
=======================================
Files 467 467
Lines 30778 30779 +1
=======================================
+ Hits 23862 23864 +2
+ Misses 6916 6915 -1
|
quentin
approved these changes
Dec 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditions were sorted nondeterministically in during both the
MakeIndexandReorderConditionsRAM transforms. This updates both to usestd::stable_sortand eliminates use of pointer comparison to sort Conditions.When building incremental builds of ddisasm with
--generate-many, these changes significantly reduce the number of object files to recompile when a trivial change is made (with the change I am making in my particular configuration, it drops from rebuilding 18 compilation units down to two).