Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Global singleton #2360

Merged
merged 1 commit into from
Nov 29, 2022
Merged

remove Global singleton #2360

merged 1 commit into from
Nov 29, 2022

Conversation

quentin
Copy link
Member

@quentin quentin commented Nov 18, 2022

Hi, this change removes the Global singleton object. This is a requirement to allow a more flexible reuse of libsouffle.

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #2360 (04ff3b7) into master (3047414) will increase coverage by 0.06%.
The diff coverage is 84.51%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2360      +/-   ##
==========================================
+ Coverage   77.43%   77.50%   +0.06%     
==========================================
  Files         470      466       -4     
  Lines       29332    30690    +1358     
==========================================
+ Hits        22713    23786    +1073     
- Misses       6619     6904     +285     
Impacted Files Coverage Δ
src/ast/Program.h 100.00% <ø> (ø)
src/ast/analysis/JoinSize.h 100.00% <ø> (ø)
src/ast/analysis/SCCGraph.h 93.75% <ø> (-6.25%) ⬇️
src/ast/transform/InlineRelations.h 50.00% <ø> (ø)
src/ast/transform/PragmaChecker.h 0.00% <ø> (ø)
src/ast2ram/provenance/UnitTranslator.h 100.00% <ø> (ø)
src/reports/DebugReport.h 53.33% <ø> (-3.81%) ⬇️
src/Global.cpp 92.85% <33.33%> (-0.30%) ⬇️
src/ast/analysis/SCCGraph.cpp 69.73% <50.00%> (ø)
src/reports/DebugReport.cpp 21.15% <50.00%> (+5.24%) ⬆️
... and 231 more

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@b-scholz b-scholz merged commit eaf5eab into souffle-lang:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants