Improve parallel load balance in the interpreter. #2313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the parallel loop partitionning from N to 20*N with N being the number of threads.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2313 +/- ##
=======================================
Coverage 77.38% 77.39%
=======================================
Files 461 461
Lines 29003 29004 +1
=======================================
+ Hits 22445 22448 +3
+ Misses 6558 6556 -2
|
|
Please, can you reformat the code changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the parallel loop partitionning from
Nto20*NwithNbeing the number of threads.We have noticed a significant improvement in thread load balancing (hence execution time) in the interpreter with this partitionning heuristics. The factor
20is a bit arbitrary, but10wasn't as good for our typical workload. This choice can be discussed / revised.