Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove -Werror from CMakeLists.txt #2299

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

ammkrn
Copy link
Contributor

@ammkrn ammkrn commented Aug 23, 2022

As requested in this issue of the homebrew-souffle repo.

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #2299 (9d4736d) into master (7dcf1af) will decrease coverage by 0.05%.
The diff coverage is 70.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2299      +/-   ##
==========================================
- Coverage   77.47%   77.41%   -0.06%     
==========================================
  Files         461      461              
  Lines       29002    29003       +1     
==========================================
- Hits        22468    22454      -14     
- Misses       6534     6549      +15     
Impacted Files Coverage Δ
src/ast2ram/provenance/UnitTranslator.cpp 93.42% <ø> (-0.06%) ⬇️
src/interpreter/Engine.cpp 84.08% <ø> (ø)
src/synthesiser/Synthesiser.h 100.00% <ø> (ø)
src/include/souffle/datastructure/BTreeDelete.h 56.85% <11.11%> (-0.59%) ⬇️
src/synthesiser/Synthesiser.cpp 83.80% <100.00%> (-0.04%) ⬇️
src/include/souffle/datastructure/LambdaBTree.h 73.28% <0.00%> (-8.40%) ⬇️
src/include/souffle/datastructure/UnionFind.h 95.60% <0.00%> (-4.40%) ⬇️
src/include/souffle/datastructure/BTree.h 98.31% <0.00%> (+0.42%) ⬆️
src/include/souffle/profile/ProfileEvent.h 97.95% <0.00%> (+5.10%) ⬆️

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

Note we need to change this so that our source-code is compiled with -werror and generated code from bison/flex is compiled without -werror

@b-scholz b-scholz closed this Aug 28, 2022
@joshuahhh
Copy link

Hello! Why was this PR closed rather than merged? (I ask because I've run into this problem myself.) Thanks!

@b-scholz b-scholz reopened this Apr 12, 2023
@b-scholz
Copy link
Member

Sorry - this was a mistake on my behalf. I meant to merge it (instead, I closed it).

@b-scholz b-scholz merged commit 9aca161 into souffle-lang:master Apr 12, 2023
@joshuahhh
Copy link

Great, thanks! Glad I could be of assistance. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants