Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate execution plan checker messages #2295

Merged

Conversation

adamjseitz
Copy link
Contributor

It can be difficult to identify the exact issue that makes an execution
plan invalid, especially with complex rules with inlined relations, for
example.

This change differentiates messages for different cases of invalid
execution plans, which makes it a bit easier for a user to identify the
issue.

It can be difficult to identify the exact issue that makes an execution
plan invalid, especially with complex rules with inlined relations, for
example.

This change differentiates messages for different cases of invalid
execution plans, which makes it a bit easier for a user to identify the
issue.
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #2295 (7dcf1af) into master (89c831c) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2295      +/-   ##
==========================================
+ Coverage   77.41%   77.47%   +0.05%     
==========================================
  Files         461      461              
  Lines       28996    29002       +6     
==========================================
+ Hits        22447    22468      +21     
+ Misses       6549     6534      -15     
Impacted Files Coverage Δ
src/ast/transform/ExecutionPlanChecker.cpp 100.00% <100.00%> (ø)
...ouffle/datastructure/ConcurrentInsertOnlyHashMap.h 81.30% <0.00%> (-0.82%) ⬇️
src/include/souffle/utility/ParallelUtil.h 85.27% <0.00%> (+0.77%) ⬆️
src/include/souffle/datastructure/UnionFind.h 100.00% <0.00%> (+4.39%) ⬆️
src/include/souffle/datastructure/LambdaBTree.h 81.67% <0.00%> (+8.39%) ⬆️

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the messages!

@b-scholz b-scholz merged commit 4639480 into souffle-lang:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants