Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Auto-Scheduler #1 #2284

Merged
merged 9 commits into from
Jun 16, 2022
Merged

Refactor Auto-Scheduler #1 #2284

merged 9 commits into from
Jun 16, 2022

Conversation

SamArch27
Copy link
Collaborator

This PR stores the join size estimate directly in the profile (instead of just the unique key count).

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #2284 (8979bdf) into master (b28fecb) will increase coverage by 0.36%.
The diff coverage is 92.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2284      +/-   ##
==========================================
+ Coverage   76.81%   77.17%   +0.36%     
==========================================
  Files         455      458       +3     
  Lines       28664    29159     +495     
==========================================
+ Hits        22017    22504     +487     
- Misses       6647     6655       +8     
Impacted Files Coverage Δ
src/ast/analysis/IOType.h 93.75% <ø> (ø)
src/ast/analysis/ProfileUse.h 100.00% <ø> (ø)
src/ast/utility/SipsMetric.h 30.00% <ø> (ø)
src/ast2ram/ClauseTranslator.h 100.00% <ø> (ø)
src/ast2ram/provenance/UnitTranslator.h 100.00% <ø> (ø)
src/ast2ram/seminaive/ClauseTranslator.cpp 97.95% <ø> (ø)
src/ast2ram/seminaive/ClauseTranslator.h 100.00% <ø> (ø)
src/ast2ram/seminaive/UnitTranslator.h 100.00% <ø> (ø)
src/ast2ram/utility/TranslatorContext.h 100.00% <ø> (ø)
src/include/souffle/RamTypes.h 100.00% <ø> (ø)
... and 43 more

@b-scholz

This comment was marked as resolved.

b-scholz
b-scholz previously approved these changes Jun 16, 2022
Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring!

@b-scholz
Copy link
Member

There is a conflict that must be resolved in UnqiueKeys.cpp/h.

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing.

@SamArch27 SamArch27 merged commit 429676c into souffle-lang:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants