Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for the debug report #2283

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Conversation

quentin
Copy link
Member

@quentin quentin commented Jun 13, 2022

  • Fix bad characters in diffs (EOF character was copied).
  • Fix syntax highlighting of souffle diffs.
  • Add syntax highlighting of souffle RAM diffs.

There is still the issue of graphs being printed as text instead of svg figures since #2092, because the code calls:

void PrecedenceGraphAnalysis::print(std::ostream& os) const {

Instead of:
void PrecedenceGraphAnalysis::printHTML(std::ostream& os) const {

Fix bad characters in diffs.
Fix syntax highlighting of souffle diffs.
Add syntax highlighting of souffle RAM diffs.
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #2283 (b28fecb) into master (8dd2354) will increase coverage by 0.00%.
The diff coverage is 26.31%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2283   +/-   ##
=======================================
  Coverage   76.80%   76.81%           
=======================================
  Files         455      455           
  Lines       28658    28664    +6     
=======================================
+ Hits        22011    22017    +6     
  Misses       6647     6647           
Impacted Files Coverage Δ
src/include/souffle/utility/FileUtil.h 62.96% <0.00%> (+0.57%) ⬆️
src/ram/StringConstant.h 72.72% <0.00%> (ø)
src/reports/DebugReport.cpp 15.90% <0.00%> (-0.37%) ⬇️
src/ast/transform/SemanticChecker.cpp 96.98% <100.00%> (+0.03%) ⬆️
...ouffle/datastructure/ConcurrentInsertOnlyHashMap.h 82.11% <0.00%> (-0.82%) ⬇️
src/include/souffle/datastructure/BTree.h 98.31% <0.00%> (+0.42%) ⬆️

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@b-scholz b-scholz merged commit 1877ba6 into souffle-lang:master Jun 13, 2022
@quentin quentin deleted the fixdbgreport branch October 23, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants