Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing override keyword #2279

Merged
merged 1 commit into from
Jun 4, 2022
Merged

Conversation

luc-tielen
Copy link
Contributor

This fixes an error I'm seeing when building souffle-haskell for OSX.

       > /tmp/nix-build-souffle-2.3.drv-0/source/src/main.cpp:306:10: error: 'endInput' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
       >     bool endInput() {
       >          ^
       > /tmp/nix-build-souffle-2.3.drv-0/source/src/main.cpp:213:18: note: overridden virtual function is here
       >     virtual bool endInput() = 0;
       >                  ^
       > 1 error generated.
       > ninja: build stopped: subcommand failed.

@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #2279 (f1962b4) into master (bec3083) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2279      +/-   ##
==========================================
- Coverage   76.92%   76.91%   -0.01%     
==========================================
  Files         455      455              
  Lines       28658    28658              
==========================================
- Hits        22045    22043       -2     
- Misses       6613     6615       +2     
Impacted Files Coverage Δ
src/main.cpp 68.62% <100.00%> (ø)
src/include/souffle/utility/ParallelUtil.h 83.72% <0.00%> (-1.56%) ⬇️

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@b-scholz b-scholz merged commit da2d778 into souffle-lang:master Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants