Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eqrel: Simplify insertAll #2268

Merged
merged 1 commit into from
May 1, 2022

Conversation

langston-barrett
Copy link
Contributor

This loop isn't parallel, so there's no reason to use getChunks. Also, use modern C++ for-each loops and structured bindings.

Refactorings suggested by @OlivierHamel.

This loop isn't parallel, so there's no reason to use getChunks. Also, use
modern C++ for-each loops and structured bindings.
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #2268 (0ebb75f) into master (c301ca8) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2268      +/-   ##
==========================================
- Coverage   76.95%   76.94%   -0.02%     
==========================================
  Files         455      455              
  Lines       28496    28496              
==========================================
- Hits        21930    21926       -4     
- Misses       6566     6570       +4     
Impacted Files Coverage Δ
...nclude/souffle/datastructure/EquivalenceRelation.h 76.76% <ø> (ø)
src/include/souffle/profile/ProfileEvent.h 92.85% <0.00%> (-5.11%) ⬇️
src/include/souffle/utility/ParallelUtil.h 83.72% <0.00%> (-1.56%) ⬇️
...ouffle/datastructure/ConcurrentInsertOnlyHashMap.h 83.73% <0.00%> (+2.43%) ⬆️

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring!

@b-scholz b-scholz merged commit 7be1e61 into souffle-lang:master May 1, 2022
@langston-barrett langston-barrett deleted the lb/eqrel-insertall branch May 1, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants