Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#2257 #2267

Merged
merged 3 commits into from
Apr 28, 2022
Merged

Fix#2257 #2267

merged 3 commits into from
Apr 28, 2022

Conversation

b-scholz
Copy link
Member

This is a small fix to correct the magic-set pipeline. The pipeline is only executed, if a magic-set transformation is issued by the user either via command-line or via a pragma statement.

Note that magic-set transformations requires explicit rules for reflexivity, symmetry and transitivity and hence equivalence relations when used in conjunction with magic-set transformations must be transformed to btree relations.

@b-scholz
Copy link
Member Author

b-scholz commented Apr 27, 2022

This is related to issue #2257 and #2190.

@b-scholz
Copy link
Member Author

Note that we could make the magic-set transformation more nuanced for eqrels but that requires quite some effort. It is more robust to replace them by b-tree relations.

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #2267 (c301ca8) into master (f9533e4) will increase coverage by 1.89%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2267      +/-   ##
==========================================
+ Coverage   75.06%   76.95%   +1.89%     
==========================================
  Files         455      455              
  Lines       28495    28496       +1     
==========================================
+ Hits        21390    21930     +540     
+ Misses       7105     6566     -539     
Impacted Files Coverage Δ
src/main.cpp 68.10% <66.66%> (-0.20%) ⬇️
src/ast/transform/SemanticChecker.cpp 96.94% <100.00%> (+0.21%) ⬆️
...ouffle/datastructure/ConcurrentInsertOnlyHashMap.h 81.30% <0.00%> (-1.63%) ⬇️
src/ast2ram/seminaive/UnitTranslator.cpp 94.29% <0.00%> (+0.27%) ⬆️
src/synthesiser/Synthesiser.cpp 83.12% <0.00%> (+0.38%) ⬆️
src/interpreter/Generator.cpp 94.92% <0.00%> (+0.72%) ⬆️
src/interpreter/Engine.cpp 87.08% <0.00%> (+0.87%) ⬆️
src/synthesiser/Relation.cpp 98.21% <0.00%> (+1.10%) ⬆️
src/include/souffle/datastructure/BTree.h 97.89% <0.00%> (+1.26%) ⬆️
src/interpreter/Node.h 98.05% <0.00%> (+1.94%) ⬆️
... and 12 more

@SamArch27 SamArch27 merged commit db45ef0 into souffle-lang:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants