fix test: getopt_long returns an int #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2264 +/- ##
==========================================
- Coverage 75.12% 75.06% -0.07%
==========================================
Files 455 455
Lines 28465 28495 +30
==========================================
+ Hits 21385 21390 +5
- Misses 7080 7105 +25
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reconciles the type of the variable
cwith the value returned bygetopt_long()in the testgetopt_long_test.cpp.Relates to #2259, I cannot guarantee this change will fix the test issue found on Apple ARM M1, unfortunately I don't have access to a machine with this architecture and Github actions does not provide this platform.