Fixed auto-scheduler for recursive rules using Selinger w/ vector #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2258 +/- ##
==========================================
+ Coverage 75.09% 75.15% +0.05%
==========================================
Files 455 455
Lines 28443 28465 +22
==========================================
+ Hits 21360 21392 +32
+ Misses 7083 7073 -10
|
b-scholz
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we used a heuristic of the average size of a recursive relation across iterations (say for delta relations).
Now we replace this by propagating a vector of costs/tuples throughout Selinger's algorithm.
This gets us the cost-optimal schedule for recursive rules.