Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't apply RemoveRelationCopies transformer to EQRELs #2244

Merged

Conversation

langston-barrett
Copy link
Contributor

Fixes #2243

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #2244 (2a7b6d0) into master (042ab12) will decrease coverage by 1.88%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2244      +/-   ##
==========================================
- Coverage   75.79%   73.90%   -1.89%     
==========================================
  Files         454      454              
  Lines       27588    27591       +3     
==========================================
- Hits        20910    20392     -518     
- Misses       6678     7199     +521     
Impacted Files Coverage Δ
src/ast/transform/MagicSet.cpp 91.93% <ø> (+0.12%) ⬆️
src/ast/transform/MinimiseProgram.cpp 100.00% <100.00%> (ø)
src/ast/transform/RemoveRelationCopies.cpp 100.00% <100.00%> (ø)
src/main.cpp 67.43% <100.00%> (ø)
src/ram/utility/Utils.h 100.00% <100.00%> (ø)
src/interpreter/EqrelIndex.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/include/souffle/datastructure/PiggyList.h 0.00% <0.00%> (-100.00%) ⬇️
src/include/souffle/datastructure/UnionFind.h 0.00% <0.00%> (-95.61%) ⬇️
...nclude/souffle/datastructure/EquivalenceRelation.h 0.00% <0.00%> (-76.77%) ⬇️
src/include/souffle/datastructure/LambdaBTree.h 0.00% <0.00%> (-73.29%) ⬇️
... and 14 more

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@b-scholz b-scholz merged commit 7f1abdc into souffle-lang:master Mar 31, 2022
@langston-barrett langston-barrett deleted the lb/fix-remove-relation-copies branch March 31, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RemoveRelationCopies transformation removes intermediate eqrel
2 participants