Not adding -g flag when compiled with NDEBUG #2238
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have
NDEBUG = off
by default and it allows only a few asserts in the program.Since #2098,
-g
is added automatically ifNDEBUG
is off.If the user compiled Souffle with the default option, using
-c
flag willl always results in the target binary being compiled with-g -O0
.I think this behaviour is probably counter-intuitive (unexpected performance regression) and probably not what
NDEBUG
was intended for.This PR removes this behaviour. Users that want the debug option should compile the datalog program using
souffle-compile.py
and pass the flag explicitly.