Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not adding -g flag when compiled with NDEBUG #2238

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

XiaowenHu96
Copy link
Collaborator

@XiaowenHu96 XiaowenHu96 commented Mar 27, 2022

We have NDEBUG = off by default and it allows only a few asserts in the program.
Since #2098, -g is added automatically if NDEBUG is off.
If the user compiled Souffle with the default option, using -c flag willl always results in the target binary being compiled with -g -O0.
I think this behaviour is probably counter-intuitive (unexpected performance regression) and probably not what NDEBUG was intended for.

This PR removes this behaviour. Users that want the debug option should compile the datalog program using souffle-compile.py and pass the flag explicitly.

@codecov
Copy link

codecov bot commented Mar 27, 2022

Codecov Report

Merging #2238 (d98a78a) into master (10a8601) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2238      +/-   ##
==========================================
+ Coverage   75.81%   75.83%   +0.01%     
==========================================
  Files         454      454              
  Lines       27587    27588       +1     
==========================================
+ Hits        20914    20920       +6     
+ Misses       6673     6668       -5     
Impacted Files Coverage Δ
src/include/souffle/profile/Reader.h 0.00% <0.00%> (ø)
src/main.cpp 67.43% <ø> (-0.10%) ⬇️
src/include/souffle/utility/ParallelUtil.h 85.27% <0.00%> (+1.55%) ⬆️
src/include/souffle/datastructure/UnionFind.h 97.80% <0.00%> (+2.19%) ⬆️
...ouffle/datastructure/ConcurrentInsertOnlyHashMap.h 83.73% <0.00%> (+2.43%) ⬆️

@b-scholz b-scholz merged commit 8fb6c11 into souffle-lang:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants