Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault in ~ProfileEventSingleton #2226

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

langston-barrett
Copy link
Contributor

Fixes #2217. There's no need to call ::instance, this destructor is already running on the singleton instance.

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #2226 (42fe95d) into master (6eb3ad0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2226      +/-   ##
==========================================
- Coverage   75.25%   75.25%   -0.01%     
==========================================
  Files         454      454              
  Lines       27572    27572              
==========================================
- Hits        20750    20749       -1     
- Misses       6822     6823       +1     
Impacted Files Coverage Δ
src/ast/analysis/typesystem/TypeConstraints.cpp 90.11% <100.00%> (ø)
src/include/souffle/SouffleInterface.h 88.99% <100.00%> (ø)
src/include/souffle/profile/ProfileEvent.h 86.95% <100.00%> (ø)
src/include/souffle/utility/ParallelUtil.h 83.72% <0.00%> (-1.56%) ⬇️
...ouffle/datastructure/ConcurrentInsertOnlyHashMap.h 83.73% <0.00%> (+0.81%) ⬆️

@b-scholz
Copy link
Member

We need to understand better what is going on. Is your library a static or a dynamic library?

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@b-scholz b-scholz merged commit c380ca2 into souffle-lang:master Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

segfault when profiling
2 participants