Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#2223 #2224

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Fix#2223 #2224

merged 1 commit into from
Mar 17, 2022

Conversation

b-scholz
Copy link
Member

The C++ generated code of a Souffle program with functors is put into the namespace souffle::functors to avoid name clashes with the Souffle system. No changes are needed in the functor libraries because the function names are defined as external "C" functions, and hence their symbols do not carry their namespace.
https://stackoverflow.com/questions/28996944/extern-c-linkage-inside-c-namespace

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #2224 (6eb3ad0) into master (f16d18d) will decrease coverage by 0.26%.
The diff coverage is 67.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2224      +/-   ##
==========================================
- Coverage   75.52%   75.25%   -0.27%     
==========================================
  Files         452      454       +2     
  Lines       27479    27572      +93     
==========================================
- Hits        20753    20750       -3     
- Misses       6726     6822      +96     
Impacted Files Coverage Δ
src/RelationTag.h 52.23% <0.00%> (-0.80%) ⬇️
src/ast/ExecutionOrder.h 100.00% <ø> (ø)
src/ast/Program.h 100.00% <ø> (ø)
src/ast/transform/ComponentInstantiation.cpp 92.36% <ø> (+0.38%) ⬆️
src/ast/transform/MinimiseProgram.h 100.00% <ø> (ø)
src/ast/transform/ResolveAliases.cpp 98.93% <ø> (ø)
src/ast/utility/SipsMetric.h 18.18% <ø> (ø)
src/ast/utility/Utils.h 100.00% <ø> (ø)
src/ast/utility/Visitor.h 57.33% <0.00%> (ø)
src/ast2ram/provenance/ClauseTranslator.h 100.00% <ø> (ø)
... and 133 more

@b-scholz
Copy link
Member Author

This is related to issue #2223.

@XiaowenHu96 XiaowenHu96 merged commit b5ba13b into souffle-lang:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants