Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup defunct delta-based SIPs #2212

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

langston-barrett
Copy link
Contributor

These all relied on information about deltas that is no longer available in the AST. See #2153.

These all relied on information about deltas that is no longer available in the
AST.
@langston-barrett langston-barrett changed the title Cleanup defunct SIPs Cleanup defunct delta-based SIPs Mar 11, 2022
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #2212 (f16d18d) into master (8893fe8) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2212      +/-   ##
==========================================
- Coverage   75.52%   75.52%   -0.01%     
==========================================
  Files         452      452              
  Lines       27394    27479      +85     
==========================================
+ Hits        20689    20753      +64     
- Misses       6705     6726      +21     
Impacted Files Coverage Δ
src/ast/utility/SipsMetric.h 18.18% <ø> (ø)
src/parser/scanner.ll 75.67% <0.00%> (-6.58%) ⬇️
...ouffle/datastructure/ConcurrentInsertOnlyHashMap.h 88.49% <0.00%> (-1.51%) ⬇️
src/main.cpp 67.52% <0.00%> (-0.55%) ⬇️
src/interpreter/Engine.cpp 87.32% <0.00%> (-0.11%) ⬇️
src/ast/Program.h 100.00% <0.00%> (ø)
src/ram/analysis/Level.h 100.00% <0.00%> (ø)
src/interpreter/Generator.cpp 94.85% <0.00%> (ø)
src/ram/transform/MakeIndex.h 66.66% <0.00%> (ø)
... and 32 more

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring!

@b-scholz
Copy link
Member

By the way, we are working on auto scheduling. I hope we will be done soon!

@b-scholz b-scholz merged commit 6e3136e into souffle-lang:master Mar 14, 2022
@langston-barrett langston-barrett deleted the lb/cleanup-sips branch March 14, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants