Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up relation generation for provenance in synthesiser and interpreter #2208

Conversation

davidwzhao
Copy link
Collaborator

Add a provenance RelationRepresentation instead of the isProvenance flags everywhere and use it for generating relations.

* Clean up relation generation for synthesiser and interpreter
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #2208 (16e0caf) into master (fcd024b) will decrease coverage by 0.00%.
The diff coverage is 77.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2208      +/-   ##
==========================================
- Coverage   75.51%   75.51%   -0.01%     
==========================================
  Files         452      452              
  Lines       27394    27473      +79     
==========================================
+ Hits        20687    20746      +59     
- Misses       6707     6727      +20     
Impacted Files Coverage Δ
src/RelationTag.h 52.23% <0.00%> (-0.80%) ⬇️
src/ast/ExecutionOrder.h 100.00% <ø> (ø)
src/ast/Program.h 100.00% <ø> (ø)
src/ast/transform/ComponentInstantiation.cpp 91.98% <ø> (ø)
src/ast/transform/MinimiseProgram.h 100.00% <ø> (ø)
src/ast/transform/ResolveAliases.cpp 98.93% <ø> (ø)
src/ast/utility/SipsMetric.h 18.18% <ø> (ø)
src/ast/utility/Utils.h 100.00% <ø> (ø)
src/ast/utility/Visitor.h 57.33% <0.00%> (ø)
src/ast2ram/provenance/ClauseTranslator.h 100.00% <ø> (ø)
... and 97 more

@b-scholz
Copy link
Member

Can you fix the conflict?

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring!

@b-scholz b-scholz merged commit d907cec into souffle-lang:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants