Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit missing '\n' in cpp includes #2206

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Conversation

pnwamk
Copy link
Contributor

@pnwamk pnwamk commented Mar 10, 2022

Without the added newlines this generates C++
which does not always compile, e.g.

compiler error: cannot compile source file "./soufflepxyz.cpp"
./soufflepxyz.cpp:4:36: warning: extra tokens at end of #include directive [-Wextra-tokens]
#include "souffle/profile/Logger.h"#include "souffle/profile/ProfileEvent.h"
                                   ^

Without the added newlines this generates C++
which does not always compile, e.g.
```
compiler error: cannot compile source file "./soufflepxyz.cpp"
./soufflepxyz.cpp:4:36: warning: extra tokens at end of #include directive [-Wextra-tokens]
#include "souffle/profile/Logger.h"#include "souffle/profile/ProfileEvent.h"
                                   ^
```
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #2206 (fcd024b) into master (8893fe8) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2206      +/-   ##
==========================================
- Coverage   75.52%   75.51%   -0.01%     
==========================================
  Files         452      452              
  Lines       27394    27394              
==========================================
- Hits        20689    20687       -2     
- Misses       6705     6707       +2     
Impacted Files Coverage Δ
src/synthesiser/Synthesiser.cpp 87.06% <0.00%> (ø)
...ouffle/datastructure/ConcurrentInsertOnlyHashMap.h 88.18% <0.00%> (-1.82%) ⬇️

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@b-scholz b-scholz merged commit 3a243a3 into souffle-lang:master Mar 10, 2022
@pnwamk pnwamk deleted the patch-2 branch March 11, 2022 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants